Ticket #1023 (closed Enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

Detail panel: use name of Custom Assoc Type as field label

Reported by: jri Owned by: jri
Priority: Major Milestone: Release 4.8.4
Component: DeepaMehta Standard Distribution Version: 4.8.3
Keywords: Cc: dgf, Malte, JuergeN
Complexity: 3 Area:
Module: deepamehta-webclient

Description (last modified by jri) (diff)

Currently input fields are labeled with the name of Custom Assoc Type only if a SIMPLE topic underlies the field. It should do so for COMPOSITE topics as well. This way e.g. "From", "To", "Date of Birth" labels would appear automatically for Date and Date/Time? fields.

At the moment the boxes of COMPOSITE topics are never labeled. This ticket proposes to make an exception, but only if both applies:

  • for the underlying assoc def a Custom Assoc Type is configured at all, and
  • the Custom Assoc Type is a SIMPLE one.

Note: names of Custom Assoc Types which are COMPOSITE are never used for labeling.

See also:
http://lists.deepamehta.de/pipermail/devel-lists.deepamehta.de/2016-October/000646.html

Change History

comment:1 Changed 5 years ago by jri

  • Status changed from new to accepted

comment:2 Changed 5 years ago by jri

  • Description modified (diff)

comment:3 Changed 5 years ago by Jörg Richter <jri@…>

In 42cfc656985731b955f770ff33e1a1d1bb33120b/deepamehta:

Detail panel: more structural markup (#1023).

The detail panels "box" div's have extended markup.
Each box div is annotated with a class that reflects the box type.
There are 4 box types:

  • simple -- box contains a simple value
  • composite -- box contains a composite value
  • related_topic -- wrapper box for topics which features both, an assoc form and a topic form, e.g. Person Address or Person Phone
  • multi -- wrapper box for multiple-value topics

This allows for more sophisticated CSS rules.

See #1023.

comment:4 Changed 5 years ago by Jörg Richter <jri@…>

In 93882e2c2cd7c9654ed7fe1e4d37f5e3483ceb97/deepamehta:

Detail panel: custom assoc type as label (#1023).

The name of a Custom Assoc Type is used for labeling a topic in the detail panel also in case the topic is COMPOSITE, provided the Custom Assoc Type is SIMPLE.

Thus, e.g. "From", "To", "Date of Birth" Date/Time? fields (from Events and Contacts modules respectively) are labeled properly, without resorting to CSS pseudo elements.

See #1023.

comment:5 Changed 5 years ago by Jörg Richter <jri@…>

In a2993ee39913b7972b0842029c0353309b9d8a7f/deepamehta:

Contacts/Events?: drop CSS pseudo elements (#1023).

Field labeling relies entirely on generic detail panel rendering logic.
Resorting to CSS pseudo elements should no longer be required.

See #1023.

comment:6 Changed 5 years ago by jri

  • Status changed from accepted to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.