Ticket #1091 (closed Defect: fixed)

Opened 2 years ago

Last modified 2 years ago

A missing "Include in Label" topic breaks webclient

Reported by: jri Owned by: jri
Priority: Major Milestone: Release 4.9.1
Component: DeepaMehta Standard Distribution Version: 4.9
Keywords: Cc: irau, Malte, JuergeN
Complexity: 3 Area: GUI / Usability
Module: deepamehta-webclient

Description (last modified by jri) (diff)

If an user reveals an assoc def's "Include in Label" topic (via detail panel) and then deletes it, the webclient will not launch anymore. The browser console reports TypeError: assoc_def.childs['dm4.core.include_in_label'] is undefined.

This is what happened recently at the dogfood installation with the assoc def between Ingo's "IT-System" and "Datenfeld" topic types.

To fix this problem:

  • The webclient must launch also when "Include in Label" topics are missing, OR
  • The webclient must prevent the user from deleting a "Include in Label" topic in the first place

Workaround:
Do NOT delete a "Include in Label" topic! Hide it instead.

UPDATE

There is a 2nd case that produces the same error: if retyping an assoc which is not an assoc def to an assoc def ("Composition Definition"/"Aggregation Definition") at a time when the role types "Parent Type" and "Child Type" are already set, then the new assoc def becomes corrupted (its "Include in Label" topic is missing). The Webclient does not launch anymore.

Workaround:

before retyping to an assoc def:

  1. make one (or both) role type ineffective by changing it to e.g. "Default" (pressing OK is not required).
  2. retype the assoc to an assoc def.
  3. make the role types effective again (that is "Parent Type"/"Child Type").

Thanks to Ingo for the detailed bug report!

Change History

comment:1 Changed 2 years ago by jri

  • Description modified (diff)

comment:2 Changed 2 years ago by jri

  • Description modified (diff)

comment:3 Changed 2 years ago by jri

  • Description modified (diff)

comment:4 Changed 2 years ago by jri

  • Summary changed from Deleting an "Include in Label" topic breaks webclient to A missing "Include in Label" topic breaks webclient

comment:5 Changed 2 years ago by jri

In https://github.com/jri/deepamehta/commit/2d90075:

Fix: missing "Include in Label" doesn't break Webclient (#1091)

See #1091

comment:6 Changed 2 years ago by jri

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.