Ticket #526 (closed Enhancement: worksforme)

Opened 7 years ago

Last modified 7 years ago

DoubleClick on item to edit

Reported by: JuergeN Owned by: jri
Priority: Major Milestone:
Component: DeepaMehta Standard Distribution Version: 4.1.2
Keywords: Cc:
Complexity: 3 Area: GUI / Usability
Module:

Description

If possible, it would be cool to enter edit mode simply by doubleclicking on an item on the canvas.

Change History

comment:1 Changed 7 years ago by jri

  • Owner set to jri
  • Status changed from new to accepted

comment:2 Changed 7 years ago by Jörg Richter

Webclient: double click a topic to edit (#526).

As a shortcut double clicking a topic enters edit mode.

Note: for File topics double clicking behavior is different: the file is opened in its origin application (as was before). File topics are not editable anyway.

See #526.

comment:3 follow-up: ↓ 4 Changed 7 years ago by JuergeN

Cool! Please add the same behaviour for associations, too.

comment:4 in reply to: ↑ 3 Changed 7 years ago by jri

Replying to JuergeN:

Cool! Please add the same behaviour for associations, too.

accepted!

comment:5 Changed 7 years ago by Jörg Richter

Webclient: double click an assoc to edit (#526).

As a shortcut double clicking an association enters edit mode.

See #526.

comment:6 Changed 7 years ago by Jörg Richter

Webclient: double click a topic to edit (#526).

As a shortcut double clicking a topic enters edit mode.

Note: for File topics double clicking behavior is different: the file is opened in its origin application (as was before). File topics are not editable anyway.

See #526.

comment:7 Changed 7 years ago by Jörg Richter

Webclient: double click an assoc to edit (#526).

As a shortcut double clicking an association enters edit mode.

See #526.

comment:8 Changed 7 years ago by JuergeN

I am not sure if double click an assoc to edit should work already, but anyway want to make sure that it does not. ;-)

comment:9 Changed 7 years ago by jri

Does association edit via doubleclick does not work for you?

It is supposed to work, and it does so for me.

Make sure you have Edit permission on that association. That is when the Edit button appears in the detail panel. Without Edit permission doubleclicking an association has no effect. (That's the same with topic doubleclicking).

comment:10 follow-up: ↓ 11 Changed 7 years ago by JuergeN

Yes, it does work, but not very relyable. It feels like it works once, but then it does not work anymore, or some other strange random behaviour. (It fully works for topics though.)

comment:11 in reply to: ↑ 10 Changed 7 years ago by jri

Replying to JuergeN:

Yes, it does work, but not very relyable. It feels like it works once, but then it does not work anymore, or some other strange random behaviour. (It fully works for topics though.)

Are you still experiencing this behavior?
Do any error messages appear in the browser console (or server log)?

From my side I can't see a problem. (Your observation comes as a surprise to me as the association doubleclick code logic is principally the same as for topics).

comment:12 Changed 7 years ago by JuergeN

Yes, I just tryed it again on the dm4nightly demo. Double clicking on an association to enter edit mode works in one out of ten to twenty approaches, if it works at all. No problem with topics though. Please try it yourself on the demo server.

comment:13 Changed 7 years ago by JuergeN

OK, let me put it this way: the speed of functional double clicking varies between the two items (type vs. assoc). When I double click on type I can click faster to enter edit than at assoc. I thought the speed would depend on my OS mouse settings, but it really seems that it makes a difference here. When double clicking at a certain (slower) speed, I can also enter edit mode on an assoc. Does that make any sense to you?

Last edited 7 years ago by JuergeN (previous) (diff)

comment:14 Changed 7 years ago by jri

All still strange to me. I see no problem with the demo server installation.

Just some general considerations:

  • In general, showing an assoc form takes more time than showing a topic form. There is a considerable delay after the doubleclick before the form shows. You need some patience.
  • Selecting a horizontal/vertical association is considerably more difficult than selecting a diagonal one. That's because of DM's assoc click detection algorithm. You can tell weather your click is detected as assoc click at all if the assoc gets selected. Note: the first click of the double click selects the assoc. So, if it is not selected, the click is not detected as an assoc click at all.
  • Note that some assocs are not editable, e.g. because of permissions. "Instantiation" assocs e.g. are not editable at all. If an assoc is not editable double clicking shows no result. You can tell weather an assoc is editable weather the Edit button appears.

I guess I should try it on your computer. Somehow my doubleclick-finger is different than yours :-)

comment:15 Changed 7 years ago by jri

  • Status changed from accepted to closed
  • Resolution set to worksforme
Note: See TracTickets for help on using tickets.