Ticket #580 (closed Task: fixed)

Opened 7 years ago

Last modified 7 years ago

Webclient: revise renderer helper + CSS classes

Reported by: jri Owned by: jri
Priority: Major Milestone: Release 4.1.3
Component: DeepaMehta Standard Distribution Version: 4.1.2
Keywords: Cc: dgf, Malte
Complexity: 3 Area:
Module: deepamehta-webclient

Description

The Webclient CSS classes "type-icon" and "menu-icon" should be dropped. They do not properly separate semantic and style.

Change History

comment:1 Changed 7 years ago by jri

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Jörg Richter

Revise renderer helper + CSS classes (#580).

BREAKING CHANGES

Webclienr Renderer Helper:

  • dm4c.render.type_icon():
    • the image element rendered is of class "icon" (not "type-icon")
  • dm4c.render.icon(src, title):
    • the image element rendered is of class "icon" (not "type-icon")
    • if "title" is not specified no tooltip will appear (formerly the "src" was shown)

Webclient CSS:

  • class "type-icon" removed.

It was defined as:

.type-icon {
    border-style: none;
    vertical-align: middle;
}
  • class "menu-icon" removed

It was defined as:

.menu-icon {
    border-style: none;
    vertical-align: middle;
    padding-right: 12px;
    width: 24px;
}

=> If your plugin relies on these classes it must be adapted.
Basically you might be interested in the reduced icon size (width: 24px).

See #580.

comment:3 Changed 7 years ago by jri

  • Status changed from accepted to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.