Ticket #732 (closed Defect: worksforme)

Opened 8 years ago

Last modified 8 years ago

dm4-csv: After a succesfull import of topics, an alert box is shown,

Reported by: Malte Owned by: Malte
Priority: Minor Milestone:
Component: DeepaMehta Standard Distribution Version: 4.4
Keywords: Cc:
Complexity: 3 Area:
Module:

Description

Bug:
After the successfull import of topics two dialogs pop up simultaniously.

  • An alert box saying that file, upload failed, despite it didnt.
  • A dialog of the csv-plugin reporting on the successfull import with e.g. display the number of created, update or delete topics.

Envisioned solutin:
Try to get rid of the alert box.

Change History

comment:1 Changed 8 years ago by Malte

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Malte

  • Status changed from accepted to closed
  • Resolution set to worksforme

Hiding alert-box and logging a TypeError? exception away which is triggered by (probably what is misusage of) dm4c.ui.dialog().open().

Note: The usage of "JSON.stringify(e)" in the catch block of open_upload_dialog (dm4-files plugin) makes errors (done in callback implementations after file upload is complete) disappear/invisible. This method seems to just swallows non-json like strings, returning just an empty object "{}".

The way it is third party plugin developers can not easily see that they have an error in their code because the alert-box of the files-plugin just says: "Exception={}"

Would there be a major disadvantage not wrapping the "e" in stringify()? I am asking since imo this would make it easier for developers to see that they have an error in their callback implementation (=file-upload-complete handler called in open_upload_dialog).

Cheers!

Note: See TracTickets for help on using tickets.