Ticket #819 (closed Defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Files with "+" character in file name are not rendered

Reported by: jri Owned by: jri
Priority: Major Milestone: Release 4.7
Component: DeepaMehta Standard Distribution Version: 4.6.1
Keywords: Cc: dgf, Malte, JuergeN
Complexity: 2 Area:
Module: deepamehta-files

Description

When clicking a File topic the underlying file (e.g. an image) is not rendered in the detail panel if the file name contains a "+" character. Apparently in the request the file name is not properly URL-encoded.

Change History

comment:1 Changed 6 years ago by jri

  • Status changed from new to accepted

comment:2 Changed 6 years ago by Jörg Richter <jri@…>

In b70cb6a25c3412c7b2c459c545ad443e34efa295/deepamehta:

Fix: files with "+" in path are rendered (#819).

A file whose path contains a "+" character is properly rendered in the detail panel.

BREAKING CHANGES

A file repository path contained in a /files/ or /filerepo/ request must be encoded as a URI component, e.g. with Javascript's encodeURIComponent function. In particular the "+" character must be encoded ("%2B"). (The encodeURI function would not work.)

Plugins that use the Files plugin's client-side open_upload_dialog(upload_url, callback) utility method are responsible for encoding the passed URL.

When using a reverse proxy it must be configured to NOT perform any URL decoding before passing the request to the application.

See #819.

comment:3 Changed 6 years ago by jri

  • Status changed from accepted to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.