Ticket #857 (closed Defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Make GUIToolkit Menu select() more strict

Reported by: jri Owned by: jri
Priority: Major Milestone: Release 4.8
Component: DeepaMehta Standard Distribution Version: 4.7
Keywords: Cc: dgf, Malte
Complexity: 3 Area: Application Framework / API
Module: deepamehta-webclient

Description (last modified by jri) (diff)

Currently when you're calling Menu's select() method with an item which doesn't exist in the menu GUIToolkit ignores that call silently. It should throw an exception instead.

Calling select() with an invalid item typically means your view is not in-sync with your view model. Currently the GUIToolkit ignores such an erroneous state instead of forcing the programmer to correct it.

Change History

comment:1 Changed 5 years ago by jri

  • Status changed from new to accepted

comment:2 Changed 5 years ago by jri

  • Description modified (diff)

comment:3 Changed 5 years ago by Jörg Richter <jri@…>

In 3c97a9ec24906cf802c0c6eda33ea20aadf34b5c/deepamehta:

GUIToolkit: Menu select() is more strict (#857).

BREAKING CHANGE

When Menu's select() method is called with an item which doesn't exist in the menu an exception is thrown.

See #857.

comment:4 Changed 5 years ago by Jörg Richter <jri@…>

comment:5 Changed 5 years ago by jri

  • Status changed from accepted to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.