Ticket #989 (closed Enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

Core API: the static resource filter should have access to the response object

Reported by: jri Owned by: jri
Priority: Major Milestone: Release 4.8.2
Component: DeepaMehta Standard Distribution Version: 4.8.1
Keywords: Cc: dgf, Malte, JuergeN
Complexity: 3 Area: Application Framework / API
Module: deepamehta-core

Description

Currently the ResourceRequestFilterListener interface looks like:

void resourceRequestFilter(HttpServletRequest request)

The user should have access to the HttpServletResponse object as well, in order to e.g. add specific response headers:

void resourceRequestFilter(HttpServletRequest request, HttpServletResponse response)

This would be needed by the Files plugin in order to support downloading files through setting the Content-Disposition header (see #661).

Change History

comment:1 Changed 5 years ago by jri

  • Status changed from new to accepted

comment:2 Changed 5 years ago by Jörg Richter <jri@…>

In c378b17cbaf5617ee627c60b9fa1d3a33ed2eb5c/deepamehta:

Core API: extend static resource filter (#989).

BREAKING CHANGE

DM passes also the response object to the ResourceRequestFilterListener event handler:

void resourceRequestFilter(HttpServletRequest request, HttpServletResponse response)

This is useful to e.g. set specific response headers.

See #989.

comment:3 Changed 5 years ago by Jörg Richter <jri@…>

In fb2ea54a3ec81e8b9875501d5c7f7d0f2f159fa2/deepamehta:

Core API: rename resourceRequestFilter() (#989).

BREAKING CHANGE

1 event listener interface renamed:

ResourceRequestFilterListener -> StaticResourceFilterListener

Corresponding handler method:

resourceRequestFilter() -> staticResourceFilter()

See #989.

comment:4 Changed 5 years ago by jri

  • Status changed from accepted to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.